Skip to content

22 class conflicts

ryanlong requested to merge 22-class-conflicts into main

Created by: ri-pandey

Description

Please provide a brief description of the changes made in this PR.

Related Issue(s)

Closes #22 (closed)

If applicable, please reference the issue(s) that this PR addresses. If the PR does not address any specific issue, you can remove this section.

Changes Made

List the main changes made in this PR. Be as specific as possible.

  • Bug fixed

Screenshots (if applicable)

Provide screenshots or GIFs that visually represent the changes. If not applicable, you can remove this section.

about_desktop about_mobile dashboard_desktop dashboard_mobile data_products_desktop data_products_mobile login_desktop login_mobile logout_desktop logout_mobile profile_desktop profile_mobile projects_desktop projects_mobile raw_data_desktop raw_data_mobile users_desktop users_mobile

Checklist

Before submitting this PR, please make sure that:

  • Your code passes linting and coding style checks.
  • You have reviewed your own code and resolved any merge conflicts.
  • You have requested a review from at least one team member.
  • Any relevant issue(s) have been linked to this PR.

Additional Information

After code splitting, most of the breaking changes occurred due to the omission of grid.css, which was bringing in the following selector:

.flex * {
  flex: 1 1 auto;
}

This affected several places in the app. Most of these only needed the addition of the flex-auto class to fix.

Besides this, there are some trivial margin/padding changes here and there, to keep the layout as close to original as possible. None of the style changes should be evident to users.

Merge request reports